Remote DebugGUI#28
Merged
Merged
Conversation
ktf
reviewed
Jul 23, 2021
ktf
reviewed
Jul 23, 2021
ktf
reviewed
Jul 23, 2021
ktf
reviewed
Jul 23, 2021
ktf
reviewed
Jul 23, 2021
ktf
reviewed
Jul 23, 2021
Member
|
Have a look at the comments and either commit the suggestion or explain why you did it that way. We can then merge the PR after tests pass. |
luigifusco
changed the title
Contributor
Author
|
Separate pollGUI functionality into separate functions. Note that atm pollGUI_gl_init needs to be called every time before pollGUI_render, as it setups the window size and other stuff through ImGui_ImplGlfwGL3_NewFrame. |
ktf
reviewed
Jul 24, 2021
ktf
reviewed
Jul 24, 2021
ktf
reviewed
Jul 24, 2021
luigifusco
changed the title
ktf
requested changes
Jul 25, 2021
ktf
left a comment
ktf
left a comment
Member
There was a problem hiding this comment.
A few more changes and then we should be there.
Member
|
Ok, you probably need to implement the same API also on the macOS version (and maybe in the dummy one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function to render a frame as a valid JSON encoded string containing draw data.
Add a function writing to a stream a group of frames as a video.